fix(123open): change DirectLink type from 'boolean' to 'bool'#1180
Merged
xrgzs merged 1 commit intoOpenListTeam:mainfrom Aug 29, 2025
Merged
fix(123open): change DirectLink type from 'boolean' to 'bool'#1180xrgzs merged 1 commit intoOpenListTeam:mainfrom
xrgzs merged 1 commit intoOpenListTeam:mainfrom
Conversation
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type annotation inconsistency in the 123open driver by changing the DirectLink field type from "boolean" to "bool" to align with Go language conventions.
- Updates the struct tag type annotation for the
DirectLinkfield in the Addition struct - Maintains consistency with Go's native boolean type naming
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ILoveScratch2
approved these changes
Aug 29, 2025
ForSourceCodeAnalysis
pushed a commit
to ForSourceCodeAnalysis/OpenList
that referenced
this pull request
Oct 4, 2025
…stTeam#1180) Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
将 Addition 结构体中 DirectLink 字段的类型标注从 "boolean" 改为 "bool"，以保持 Go 语言类型一致性。
Motivation and Context / 背景
https://t.me/OpenListTeam/114048
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。